feat: Create UserCreationService and use in API V1 create user endpoint
#19150
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| identityProvider?: IdentityProvider; | ||
| } | ||
|
|
||
| export class UserCreationService { |
There was a problem hiding this comment.
This is exactly what we are looking for with application services coordinating these calls. Very nice.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/10/25)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
@Udit-takkar I have this PR in the stack that addresses this |
| const log = logger.getSubLogger({ prefix: ["[userCreationService]"] }); | ||
|
|
||
| export class UserCreationService { | ||
| static async createUser({ data }: { data: CreateUserInput }) { |
There was a problem hiding this comment.
Why not directly pass CreateUserInput to the createUser function?
static async createUser(data: CreateUserInput) {}
| username: slugify(username), | ||
| organizationId: organizationId, | ||
| uid: ProfileRepository.generateProfileUid(), | ||
| organizationId: organizationIdValue, |
There was a problem hiding this comment.
We are creating a profile but shouldn't we also create a user membership for the org? I think that org users have both membership and profile.
|
@supalarry to address your feedback, I have a PR stack where I handle org creation logic #19201 This addresses your comments:
|
joeauyeung
dismissed stale reviews from supalarry and Udit-takkar
via
527539e
What does this PR do?
UserCreationServiceMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist